🐛 fix(markdown): normalize excessive blank lines in Markdown rendering#1300
Merged
🐛 fix(markdown): normalize excessive blank lines in Markdown rendering#1300
Conversation
- Limit consecutive blank lines to 2 in Markdown output - Add tests for excessive and three blank lines This improves output consistency and fixes edge cases in Markdown rendering.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve consistency of Markdown rendering output by normalizing runs of blank lines (capping consecutive blank lines), and adjusts tests to reflect the new normalized output behavior.
Changes:
- Clamp inter-node newline insertion in
Markdownrendering to a maximum of 2 newlines. - Add regression tests covering excessive blank lines between blocks.
- Update an XML CLI integration test expectation to match the new normalized trailing-newline behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/mq-markdown/src/markdown.rs | Clamps inserted newlines to reduce excessive blank lines; adds regression test cases. |
| crates/mq-run/tests/integration_tests.rs | Updates expected XML output string to reflect normalized newline behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves output consistency and fixes edge cases in Markdown rendering.
https://github.com/harehare/mq/discussions/1299