✨ feat(mq-lang): add ltrim and rtrim builtins for string/markdown whitespace trimming#1281
Merged
✨ feat(mq-lang): add ltrim and rtrim builtins for string/markdown whitespace trimming#1281
Conversation
Owner
harehare
commented
Feb 15, 2026
harehare
commented
- Add ltrim and rtrim built-in functions to trim whitespace from the left/right of strings and Markdown nodes
- Register new builtins in hash dispatch and documentation
- Add integration tests for ltrim and rtrim builtins
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two new built-in functions ltrim and rtrim for trimming whitespace from strings and Markdown nodes. The implementation follows established patterns in the codebase for string manipulation functions, providing consistent handling across String, Markdown, and None types.
Changes:
- Adds
LTRIMandRTRIMbuiltin function implementations usingtrim_start()andtrim_end()respectively - Registers the new builtins in the hash dispatch system with constants and match arms
- Adds comprehensive documentation for both functions in
BuiltinFunctionDoc - Includes integration tests verifying correct behavior on string inputs with whitespace
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/mq-lang/src/eval/builtin.rs | Adds LTRIM/RTRIM builtin implementations, hash constants, hash dispatch registration, and documentation entries |
| crates/mq-lang/tests/integration_tests.rs | Adds integration test cases for ltrim() and rtrim() functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.