🐛 fix(eval): propagate actual module error instead of always returning NotFound#1232
Merged
🐛 fix(eval): propagate actual module error instead of always returning NotFound#1232
Conversation
…g NotFound Refactor module import error handling from if-let chain to match expression, which properly propagates the original ModuleError variant (e.g., IOError) instead of converting all non-AlreadyLoaded errors to NotFound.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors module import error handling in the evaluator to preserve and propagate the original ModuleError variants (e.g., IOError) instead of collapsing most failures into NotFound.
Changes:
- Replaced an
if let/else ifchain with amatchto handle module load results more explicitly. - Propagated non-
AlreadyLoadedmodule load errors directly asRuntimeError::ModuleLoadError. - Updated a unit test expectation to assert
IOErrorinstead ofNotFound.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor module import error handling from if-let chain to match expression, which properly propagates the original ModuleError variant (e.g., IOError) instead of converting all non-AlreadyLoaded errors to NotFound.