🐛 fix(formatter): handle selector attributes in assignment expressions#1228
Merged
🐛 fix(formatter): handle selector attributes in assignment expressions#1228
Conversation
Format selector nodes (e.g., value.test) directly using format_selector in assignment expressions to avoid inserting unwanted newlines from leading trivia when using format_node.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a formatting issue where assignment expressions containing selector attributes (e.g., value.test) were incorrectly inserting unwanted newlines. The fix ensures that selector nodes are formatted directly using format_selector instead of format_node, which was applying leading trivia inappropriately.
Changes:
- Added special handling for
Selectornodes in assignment expressions to prevent unwanted newline insertion - Added a test case to verify the fix for assignment expressions with selector attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format selector nodes (e.g., value.test) directly using format_selector in assignment expressions to avoid inserting unwanted newlines from leading trivia when using format_node.