Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the debug function by moving it from Rust builtin implementation to a mq language implementation in builtin.mq. This simplifies the codebase by implementing the debug functionality in pure mq code rather than as a native Rust builtin function.
Changes:
- Removed the native Rust implementation of the
DEBUGbuiltin function - Added a pure mq implementation of the
debugfunction inbuiltin.mq - Cleaned up associated hash constants, function lookup mappings, and documentation entries
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/mq-lang/src/eval/builtin.rs | Removed the native Rust DEBUG builtin function definition, its hash constant, lookup mapping, and documentation entry |
| crates/mq-lang/builtin.mq | Added new mq language implementation of the debug function with equivalent functionality |
|
|
||
| # Prints the debug information of the given value(s). | ||
| def debug(*args): | ||
| if (len(args) == 1): |
There was a problem hiding this comment.
The conditional check len(args) == 1 doesn't handle the case where args is empty. The original Rust implementation accepted 1 to u8::MAX arguments, but this version may behave unexpectedly with zero arguments.
Suggested change
| if (len(args) == 1): | |
| if (len(args) == 0): | |
| stderr("DEBUG: (no arguments)") | |
| elif (len(args) == 1): |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.