Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Zed editor extension to provide language support for mq, including syntax highlighting via Tree-sitter, LSP integration with auto-download functionality, and editor configuration for .mq files.
Changes:
- Adds Zed extension implementation with automatic LSP binary management
- Configures Tree-sitter grammar integration and syntax highlighting rules
- Includes documentation and build configuration for the extension
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/zed/src/lib.rs | Core extension logic for LSP binary detection, download, and lifecycle management |
| editors/zed/languages/mq/indents.scm | Tree-sitter indentation rules for mq language constructs |
| editors/zed/languages/mq/highlights.scm | Syntax highlighting definitions for keywords, operators, and language elements |
| editors/zed/languages/mq/config.toml | Language configuration including brackets, comments, and file associations |
| editors/zed/grammars/mq | Git submodule reference to tree-sitter-mq grammar |
| editors/zed/extension.toml | Extension metadata and configuration for Zed marketplace |
| editors/zed/README.md | User documentation for installation and usage |
| editors/zed/Cargo.toml | Rust package configuration for the extension |
| editors/zed/.gitignore | Exclusions for generated files |
| Cargo.toml | Workspace member addition for the Zed extension |
harehare
force-pushed
the
feat/support-zed
branch
from
bc33540 to
a4cd40b
Compare
…expression to indentation rules
|
|
||
| [grammars.mq] | ||
| repository = "https://github.com/harehare/tree-sitter-mq" | ||
| commit = "main" |
There was a problem hiding this comment.
The grammar is pinned to the 'main' branch which is not a stable reference and may break if the tree-sitter-mq repository changes. Consider pinning to a specific commit hash or tag instead to ensure reproducible builds.
Suggested change
| commit = "main" | |
| # Pinned to a specific commit for reproducible builds. Update when upgrading the grammar. | |
| commit = "0123456789abcdef0123456789abcdef01234567" |
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.