More realistic request socket interface#145
Merged
Conversation
Merged
geek
approved these changes
Apr 25, 2022
cjihrig
approved these changes
Apr 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing some testing with hapi, I found that hapi has certain behaviors when
req.socketis present versus when it isn't. With the change in #144 it becomes present for all shot requests. In turn, hapi requires a more realistic mock request socket since it actually exercises some of its interface. I have implemented a minimal mock socket for shot, which turns out to be a similar direction that light-my-request took as well.