Skip to content

Comments

More realistic request socket interface#145

Merged
devinivy merged 8 commits intomasterfrom
more-realistic-req-socket
May 9, 2022
Merged

More realistic request socket interface#145
devinivy merged 8 commits intomasterfrom
more-realistic-req-socket

Conversation

@devinivy
Copy link
Member

@devinivy devinivy commented Apr 25, 2022

After doing some testing with hapi, I found that hapi has certain behaviors when req.socket is present versus when it isn't. With the change in #144 it becomes present for all shot requests. In turn, hapi requires a more realistic mock request socket since it actually exercises some of its interface. I have implemented a minimal mock socket for shot, which turns out to be a similar direction that light-my-request took as well.

@devinivy devinivy added the feature New functionality or improvement label Apr 25, 2022
@devinivy devinivy added this to the 6.0.0 milestone Apr 25, 2022
@devinivy devinivy changed the base branch from v6 to master April 25, 2022 02:58
@devinivy devinivy changed the base branch from master to v6 April 25, 2022 02:58
@devinivy devinivy mentioned this pull request Apr 25, 2022
Base automatically changed from v6 to master May 9, 2022 03:27
@devinivy devinivy merged commit d7fa894 into master May 9, 2022
@devinivy devinivy deleted the more-realistic-req-socket branch May 9, 2022 03:34
@devinivy devinivy self-assigned this May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality or improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants