Enforce that response streams are always Stream.Readable#4349
Merged
Conversation
Member
Author
|
The failure appearing on node v12 will be resolved once #4346 lands and we stop supporting node v12— it's a syntax issue. I think it's alright to look past this for review purposes. |
devinivy
force-pushed
the
response-readable-stream
branch
from
c3aae62 to
369f4d4
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping support for old/non-standard response streams. If you want to use one of these, you can try repairing it into a
Stream.Readableby piping it through aStream.PassThrough. I ended-up keeping the old stream duck-typing logic around for the purpose of helping users catch any issues when moving from v20 to v21, rather than treating legacy streams as an object response.Resolves #4293