Skip to content
This repository was archived by the owner on Jul 15, 2021. It is now read-only.

Commit 771b36b

Browse files
committed
Apply suggestions from code review
In includes: * Regenerate the package-lock.json file compatible with Node v10; * Add .gitattributes file;
1 parent 2250469 commit 771b36b

File tree

3 files changed

+987
-14772
lines changed

3 files changed

+987
-14772
lines changed

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Makes sure that Git automatically detects what files are considered "text" and use LF as the line ending in all OS
2+
* text=auto eol=lf

CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,10 @@ Your contributions to the project are very welcome. If you would like to fix a b
44

55
To help us merge your Pull Request, please make sure you follow these points:
66

7-
1. Please make your fix on a separate branch based on `develop` branch. This makes merging much easier.
8-
2. Do not edit files in `dist/` directory (e.g: `formula-parser.js`, `formula-parser.min.js`). Instead, edit files inside the `src/` directory and then use `gulp` or `npm scripts` to make a build.
9-
3. **Very important:** For any change that you make, **please try to also add a test case(s)** in `tests/unit/` or `test/integration/`. This helps us understand the issue and make sure that it will stay fixed forever.
7+
1. Please make sure that you're using the NodeJS in the proper version. The project requires version 10.
8+
2. Make your fix on a separate branch based on `develop` branch. This makes merging much easier.
9+
3. Do not edit files in `dist/` directory (e.g: `formula-parser.js`, `formula-parser.min.js`). Instead, edit files inside the `src/` directory and then use `gulp` or `npm scripts` to make a build.
10+
4. **Very important:** For any change that you make, **please try to also add a test case(s)** in `tests/unit/` or `test/integration/`. This helps us understand the issue and make sure that it will stay fixed forever.
1011
5. Describe the problem in the Pull Request description (of course you would do it, why do I mention that?).
1112
6. **Very important:** Make Pull Request ready to merge into `develop` branch.
1213

0 commit comments

Comments
 (0)