Config: record empty heartbeat legacy removal

gumadeiras · gumadeiras · commit 1714ffe6fc1e · 2026-03-03T20:26:18.000-05:00
diff --git a/src/config/legacy-migrate.test.ts b/src/config/legacy-migrate.test.ts
@@ -208,6 +208,16 @@ describe("legacy migrate heartbeat config", () => {
     expect((res.config as { heartbeat?: unknown } | null)?.heartbeat).toBeUndefined();
     expect((res.config as { agent?: unknown } | null)?.agent).toBeUndefined();
   });
+
+  it("records a migration change when removing empty top-level heartbeat", () => {
+    const res = migrateLegacyConfig({
+      heartbeat: {},
+    });
+
+    expect(res.changes).toContain("Removed empty top-level heartbeat.");
+    expect(res.config).not.toBeNull();
+    expect((res.config as { heartbeat?: unknown } | null)?.heartbeat).toBeUndefined();
+  });
 });
 
 describe("legacy migrate controlUi.allowedOrigins seed (issue #29385)", () => {
diff --git a/src/config/legacy.migrations.part-3.ts b/src/config/legacy.migrations.part-3.ts
@@ -343,6 +343,9 @@ export const LEGACY_CONFIG_MIGRATIONS_PART_3: LegacyConfigMigration[] = [
         raw.channels = channels;
       }
 
+      if (!agentHeartbeat && !channelHeartbeat) {
+        changes.push("Removed empty top-level heartbeat.");
+      }
       delete raw.heartbeat;
     },
   },

Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,9 @@ export const LEGACY_CONFIG_MIGRATIONS_PART_3: LegacyConfigMigration[] = [`
`343`	`343`	`raw.channels = channels;`
`344`	`344`	`}`
`345`	`345`
	`346`	`+ if (!agentHeartbeat && !channelHeartbeat) {`
	`347`	`+ changes.push("Removed empty top-level heartbeat.");`
	`348`	`+ }`
`346`	`349`	`delete raw.heartbeat;`
`347`	`350`	`},`
`348`	`351`	`},`