Add missing types for the Exception class properties#1583
Merged
nknapp merged 11 commits intohandlebars-lang:4.xfrom Oct 28, 2019
Merged
Add missing types for the Exception class properties#1583nknapp merged 11 commits intohandlebars-lang:4.xfrom
nknapp merged 11 commits intohandlebars-lang:4.xfrom
Conversation
Collaborator
|
Thanks for the PR. Test cases for the typings go into the |
Contributor
Author
|
OK. I'll add some. |
Contributor
Author
|
@nknapp I've added some code using the defined types in the |
nknapp
requested changes
Oct 27, 2019
Collaborator
nknapp
left a comment
There was a problem hiding this comment.
Thanks for adapting my change requests. I have now had a chance to have a closer look and I would you to make further changes. Please have a look at my review comments.
Contributor
Author
|
@nknapp Thanks for the detail review. I'll make the changes push again. |
34f3b8f to
168d4f9
Compare
Contributor
Author
|
Hi @nknapp I've pushed new changes as per your suggestions. Could you please review again and let me know if this looks good? Thanks! |
Collaborator
|
Superb. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1576
Add missing type declarations for the properties of
Exceptionclass.What has changed?
functionto aclassso as to declare fields.thisobject in the source file.nodeof typehbs.AST.Node.4.x-branch contains the latest version. Please target that branch in the PR.@nknapp Not sure if this change requires a test too. If yes, please suggest and show me some examples and I can do it. Thanks!
PS: I tried
npm checkTypesandnpm testwhich all passed for me - not sure what else I need to do.