Include partial name in 'undefined partial' exception message#1121
Merged
kpdecker merged 2 commits intohandlebars-lang:masterfrom Oct 19, 2015
Merged
Conversation
Collaborator
|
Glad to pull this in but lets go with template strings here (and use |
Author
|
Thanks, @kpdecker — I made those changes and appreciate the review. (I tend to shy away from ES6 stuff until asked for it at this point.) |
Collaborator
|
Looks great. Will merge after travis finishes. |
kpdecker
added a commit
that referenced
this pull request
Oct 19, 2015
Include partial name in 'undefined partial' exception message
Collaborator
|
Released in 4.0.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My project has occasionally had production issues with undefined partials due to programmer error, but we use enough partials that figuring out what's wrong can take a bit of sleuthing.
This patch changes the exception message to include the name of the partial in the error message. This seems in keeping with the general style of the codebase (for example, see various instances in runtime.js — e.g.: