Can you add a test to ensure that this does not regress and I'll be glad to
add. spec/regressions.js might be a good place to add this, otherwise
spec/partials.js

On Tue, Jul 7, 2015 at 8:05 PM Andrey Kravtsov [email protected]
wrote:

When partial's indent option is used, runtime compilation of string
partial is failing for partials produced by Handlebars.SafeString because
of split method call.

let lines = result.split('\n');

https://github.com/wycats/handlebars.js/blob/2c1d509c6cafea145ece5ff9bc8b5c2ca98f9749/lib/handlebars/runtime.js#L52

See jsfiddle demo http://jsfiddle.net/j1j60b0u/ for details.

I have fixed it in a straight way by implicitly calling result.toString().

You can view, comment on, or merge this pull request online at:

#1054
Commit Summary

• Ensure that partial invoke result is a string before splitting it
  for indenting

File Changes

• M lib/handlebars/runtime.js
  https://github.com/wycats/handlebars.js/pull/1054/files#diff-0 (2)

Patch Links:

• https://github.com/wycats/handlebars.js/pull/1054.patch
• https://github.com/wycats/handlebars.js/pull/1054.diff

—
Reply to this email directly or view it on GitHub
#1054.

I'm little bit unsure about exact solution to this problem. Should partial always return a string only?
If so it'll be better to call result.toString() inside invokePartial and not in the any conditions later, e.g. one in invokePartialWrapper.
Could you tell me about partial's main concept? Is it just a part of the template (and in that case it should always return string), or partial in Handlebars is something more than just a piece of template (and maybe it should return objects like SafeString in some cases)?

You raise an interesting point. I was surprised that you were able to cause a safe string return from a partial in the first place. Modifying your example a little bit, http://jsfiddle.net/j1j60b0u/1/, shows that a template with a simple wrapper can return a SafeString as well, which could lead to issues down the road. I think we need to make sure that the return from any template, partial or not, is always a string and have proper tests to ensure that :)

@RD5, I went the route of consistent string return from the API and implemented your test case there. Thanks for the report!

Thank you!