fix(schema): reject duplicate field names, duplicate enum symbols, an… #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d invalid fixed sizes
Contributor
Author
|
@nrwiersma thanks for merging! Is there an estimate for when the next release will be published that includes these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This PR adds stricter schema validation to bring hamba/avro in closer alignment with the Avro specification and behavior seen in the official Apache implementations. This ensures proper validation when parsing schemas.
Changes
Reject duplicate field names in record schemas (Avro Python ref)
Reject duplicate symbols in enum schemas (Avro Python ref
Disallow negative fixed sizes (Avro Python ref)
How did I test it?
make test: All existing tests pass, and additional test cases have been added and pass to verify the new validation checks.References
These changes address issues similar to those reported in the official Avro implementations: