Add WithBlockSize to trigger early flushes #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunsgaard
force-pushed
the
feat/maxBufSize
branch
from
ef971ee to
a96cfd1
Compare
nrwiersma
reviewed
May 21, 2025
Member
nrwiersma
left a comment
nrwiersma
left a comment
There was a problem hiding this comment.
Looks good, could you add a test please.
brunsgaard
force-pushed
the
feat/maxBufSize
branch
from
a96cfd1 to
4829791
Compare
Contributor
Author
|
Added a test and performed a bit of refactor, please have a look when you have time. |
This change adds a new encoder option, `WithBlockSize`, which allows users to specify a maximum uncompressed buffer size. When this limit is reached, `writerBlock()` is triggered (after the record is written to the internal buffer) to avoid excessive memory usage when writing large individual records. This complements the existing blockLength threshold.
brunsgaard
force-pushed
the
feat/maxBufSize
branch
2 times, most recently
from
b952b25 to
20501b2
Compare
nrwiersma
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new encoder option,
WithBlockSize, which allows users to specify a maximum uncompressed buffer size. When this limit is reached,writerBlock()is triggered (after the record is written to the internal buffer) to avoid excessive memory usage when writing large individual records.This complements the existing blockLength threshold.
Fixes #537
We are running a version of this lib, that includes the commit in our current pipelines.