Skip to content

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 2, 2025

What type of PR is this?

/area ui
/area editor
/milestone 2.22.x
/kind improvement

What this PR does / why we need it:

This PR improves the overall editor UI and interaction logic. The main updates include:

  • Updated icons.
  • Added some basic wrapped components like BubbleButton, DropdownItem, and Input to make them easier for plugins to use.
  • Simplified the Bubble menu interactions for some extensions.
  • Plus a few other small styling tweaks and polish.

Does this PR introduce a user-facing change?

优化编辑器的整体样式和交互逻辑

@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Dec 2, 2025
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. labels Dec 2, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign guqing for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 2, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7982

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7982

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7982

@halo-dev/ui-shared

npm i https://pkg.pr.new/@halo-dev/ui-shared@7982

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7982

commit: 32dccb4

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.18%. Comparing base (42c374d) to head (32dccb4).
⚠️ Report is 294 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7982      +/-   ##
============================================
+ Coverage     59.55%   61.18%   +1.62%     
- Complexity     3812     3933     +121     
============================================
  Files           677      689      +12     
  Lines         23248    23507     +259     
  Branches       1500     1522      +22     
============================================
+ Hits          13846    14382     +536     
+ Misses         8764     8397     -367     
- Partials        638      728      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby requested a review from LIlGG December 4, 2025 04:16
@ruibaby ruibaby requested review from LIlGG and removed request for LIlGG December 8, 2025 06:52
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 8, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the editor's UI and interaction logic by modernizing the icon set, introducing reusable component wrappers, and streamlining bubble menu interactions. The changes focus on improving code maintainability and user experience through consistent styling and better component abstractions.

Key changes:

  • Migrated from MDI/RI icons to Lucide/Mingcute icon sets for visual consistency
  • Introduced BubbleButton, DropdownItem, and Input base components for better reusability and plugin integration
  • Refactored bubble menu and toolbar item type definitions with cleaner component prop interfaces
  • Improved editor layout structure with better responsive design and spacing

Reviewed changes

Copilot reviewed 100 out of 101 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/packages/editor/src/types/index.ts Refactored type definitions to use dedicated component prop interfaces
ui/packages/editor/src/components/base/* Added reusable Input and DropdownItem components
ui/packages/editor/src/components/bubble/* Reorganized bubble menu components with new BubbleButton wrapper
ui/packages/editor/src/extensions/**/* Updated all extensions to use new icon sets and component patterns
ui/packages/editor/src/styles/base.scss Restructured editor layout with improved responsive design
ui/packages/editor/src/locales/*.yaml Added new translation keys for input labels and UI elements
ui/packages/editor/src/components/upload/ResourceReplaceButton.vue New component for resource replacement with consistent UI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ruibaby ruibaby merged commit 760ba23 into halo-dev:main Dec 10, 2025
17 of 18 checks passed
@ruibaby ruibaby modified the milestones: 2.22.x, 2.22.0 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant