-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Optimize editor styles #7982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize editor styles #7982
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/ui-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7982 +/- ##
============================================
+ Coverage 59.55% 61.18% +1.62%
- Complexity 3812 3933 +121
============================================
Files 677 689 +12
Lines 23248 23507 +259
Branches 1500 1522 +22
============================================
+ Hits 13846 14382 +536
+ Misses 8764 8397 -367
- Partials 638 728 +90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Expanded the selectable group size options in BubbleItemGroupSize.vue from 6 to 10, allowing users to choose larger group sizes for gallery items.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes the editor's UI and interaction logic by modernizing the icon set, introducing reusable component wrappers, and streamlining bubble menu interactions. The changes focus on improving code maintainability and user experience through consistent styling and better component abstractions.
Key changes:
- Migrated from MDI/RI icons to Lucide/Mingcute icon sets for visual consistency
- Introduced
BubbleButton,DropdownItem, andInputbase components for better reusability and plugin integration - Refactored bubble menu and toolbar item type definitions with cleaner component prop interfaces
- Improved editor layout structure with better responsive design and spacing
Reviewed changes
Copilot reviewed 100 out of 101 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/packages/editor/src/types/index.ts | Refactored type definitions to use dedicated component prop interfaces |
| ui/packages/editor/src/components/base/* | Added reusable Input and DropdownItem components |
| ui/packages/editor/src/components/bubble/* | Reorganized bubble menu components with new BubbleButton wrapper |
| ui/packages/editor/src/extensions/**/* | Updated all extensions to use new icon sets and component patterns |
| ui/packages/editor/src/styles/base.scss | Restructured editor layout with improved responsive design |
| ui/packages/editor/src/locales/*.yaml | Added new translation keys for input labels and UI elements |
| ui/packages/editor/src/components/upload/ResourceReplaceButton.vue | New component for resource replacement with consistent UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



What type of PR is this?
/area ui
/area editor
/milestone 2.22.x
/kind improvement
What this PR does / why we need it:
This PR improves the overall editor UI and interaction logic. The main updates include:
Does this PR introduce a user-facing change?