Skip to content

Refactor dropdown component #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 5 commits into from
Dec 1, 2025
Merged

Refactor dropdown component #7978

ruibaby merged 5 commits into from
Dec 1, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 30, 2025

What type of PR is this?

/area ui
/kind improve
/milestone 2.22.x

What this PR does / why we need it:

Refactor the @halo-dev/components Dropdown component to fully re-export floating-vue instead. This switches us to using the original floating-vue components directly, so Core, the editor, and other plugins can all rely on the same unified Dropdown. It also allows full customization and helps reduce bundle size.

Does this PR introduce a user-facing change?

重构 `@halo-dev/components` 中的 Dropdown 组件，改为完全使用 `floating-vue` 的原始组件

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Nov 30, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Nov 30, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 30, 2025

@ruibaby: The label(s) kind/improve cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/area ui
/kind improve
/milestone 2.22.x

What this PR does / why we need it:

Refactor the @halo-dev/components Dropdown component to fully re-export floating-vue instead. This switches us to using the original floating-vue components directly, so Core, the editor, and other plugins can all rely on the same unified Dropdown. It also allows full customization and helps reduce bundle size.

Does this PR introduce a user-facing change?

重构 `@halo-dev/components` 中的 Dropdown 组件，改为完全使用 `floating-vue` 的原始组件

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby ruibaby added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 30, 2025
@codecov
Copy link

codecov bot commented Nov 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.19%. Comparing base (42c374d) to head (c522c56).
⚠️ Report is 286 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7978      +/-   ##
============================================
+ Coverage     59.55%   61.19%   +1.63%     
- Complexity     3812     3933     +121     
============================================
  Files           677      689      +12     
  Lines         23248    23507     +259     
  Branches       1500     1522      +22     
============================================
+ Hits          13846    14385     +539     
+ Misses         8764     8395     -369     
- Partials        638      727      +89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7978

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7978

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7978

@halo-dev/ui-shared

npm i https://pkg.pr.new/@halo-dev/ui-shared@7978

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7978

commit: c522c56

@ruibaby ruibaby merged commit fca4c32 into halo-dev:main Dec 1, 2025
11 of 12 checks passed
@ruibaby ruibaby deleted the refactor/dropdown-component branch December 1, 2025 03:32
@ruibaby ruibaby modified the milestones: 2.22.x, 2.22.0 Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

1 participant

@ruibaby