Remove yjs dependency from editor package #7971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note-none
f2c-ci-robot
bot
added
the
kind/cleanup
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@halo-dev/api-client
@halo-dev/components
@halo-dev/richtext-editor
@halo-dev/ui-shared
@halo-dev/ui-plugin-bundler-kit
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7971 +/- ##
============================================
+ Coverage 59.55% 61.19% +1.63%
- Complexity 3812 3933 +121
============================================
Files 677 689 +12
Lines 23248 23507 +259
Branches 1500 1522 +22
============================================
+ Hits 13846 14385 +539
+ Misses 8764 8395 -369
- Partials 638 727 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
f2c-ci-robot
bot
added
release-note
ruibaby
added
the
kind/improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area ui
/kind cleanup
/milestone 2.22.x
What this PR does / why we need it:
Remove the yjs dependency from the editor package. This dependency comes from
@tiptap/extension-drag-handle, which is used to implement block-level dragging. It looks like this package includes some special handling for collaboration features when used together with Tiptap’s collaboration extension (@tiptap/extension-collaboration). Since we don’t use any collaboration features at all, having yjs bundled in our build is unnecessary and adds a lot of extra weight.It also seems unlikely that the Tiptap team will address this issue anytime soon, so we decided to patch the dependency ourselves. Reference:
https://github.com/ueberdosis/tiptap/discussions/5787Does this PR introduce a user-facing change?