Skip to content

Refactor profile authentication tab #7950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 1 commit into from
Nov 21, 2025
Merged

Refactor profile authentication tab #7950

ruibaby merged 1 commit into from
Nov 21, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 19, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.22.x

What this PR does / why we need it:

Merge social login and two-factor authentication on the uc profile page into a single tab named 'Authentication'

image

Does this PR introduce a user-facing change?

优化个人中心身份认证设置，将三方登录与两步认证合并到一个选项卡

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Nov 19, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Nov 19, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 19, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 19, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Nov 19, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.18%. Comparing base (42c374d) to head (068b2d7).
⚠️ Report is 274 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7950      +/-   ##
============================================
+ Coverage     59.55%   61.18%   +1.62%     
- Complexity     3812     3933     +121     
============================================
  Files           677      689      +12     
  Lines         23248    23507     +259     
  Branches       1500     1522      +22     
============================================
+ Hits          13846    14382     +536     
+ Misses         8764     8397     -367     
- Partials        638      728      +90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruibaby ruibaby merged commit 889ec58 into halo-dev:main Nov 21, 2025
9 of 10 checks passed
@ruibaby ruibaby deleted the refactor/uc-profile-auth branch November 21, 2025 07:04
@ruibaby ruibaby modified the milestones: 2.22.x, 2.22.0 Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

1 participant

@ruibaby