Skip to content

Refactor permission checks to use shared utils #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
f2c-ci-robot merged 3 commits into from
Oct 23, 2025
Merged

Refactor permission checks to use shared utils #7853

f2c-ci-robot merged 3 commits into from
Oct 23, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 22, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.22.x

What this PR does / why we need it:

This PR introduces a developer-friendly utility for checking UI permissions, which is also exposed for use by plugins.

Usage:

import { utils } from "@halo-dev/console-shared"

utils.permission.has(['any:permission'])

Does this PR introduce a user-facing change?

在 `@halo-dev/console-shared` 包中提供 UI 权限检查工具

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 22, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Oct 22, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 22, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen October 22, 2025 14:36
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 22, 2025 •
edited
Loading

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7853

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7853

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7853

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7853

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7853

commit: 6e5dac4

@codecov
Copy link

codecov bot commented Oct 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.24%. Comparing base (42c374d) to head (6e5dac4).
⚠️ Report is 291 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7853      +/-   ##
============================================
+ Coverage     59.55%   61.24%   +1.68%     
- Complexity     3812     3924     +112     
============================================
  Files           677      687      +10     
  Lines         23248    23422     +174     
  Branches       1500     1516      +16     
============================================
+ Hits          13846    14345     +499     
+ Misses         8764     8356     -408     
- Partials        638      721      +83

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JohnNiang
JohnNiang approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit cc4ba4a into halo-dev:main Oct 23, 2025
12 checks passed
@ruibaby ruibaby deleted the feat/add-permission-utils branch October 23, 2025 09:52
@ruibaby ruibaby modified the milestones: 2.22.x, 2.22.0 Oct 23, 2025
@ruibaby ruibaby mentioned this pull request Oct 24, 2025
Closed
@ruibaby ruibaby added the area/plugin Issues or PRs related to the Plugin Provider label Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ruibaby @JohnNiang