Skip to content

feat: support using Chinese symbols to invoke the suggestion menu #7840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
f2c-ci-robot merged 1 commit into from
Oct 21, 2025
Merged

feat: support using Chinese symbols to invoke the suggestion menu #7840

f2c-ci-robot merged 1 commit into from
Oct 21, 2025

Conversation

@LIlGG
Copy link
Member

@LIlGG LIlGG commented Oct 21, 2025 •
edited
Loading

What type of PR is this?

/kind feature
/area editor

What this PR does / why we need it:

支持使用中文符号、唤起建议菜单

Which issue(s) this PR fixes:

Fixes #7770

Does this PR introduce a user-facing change?

支持使用中文符号、唤起建议菜单

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/editor Issues or PRs related to the Editor labels Oct 21, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wan92hen October 21, 2025 04:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2025

Open in StackBlitz

@halo-dev/api-client

npm i https://pkg.pr.new/@halo-dev/api-client@7840

@halo-dev/components

npm i https://pkg.pr.new/@halo-dev/components@7840

@halo-dev/richtext-editor

npm i https://pkg.pr.new/@halo-dev/richtext-editor@7840

@halo-dev/console-shared

npm i https://pkg.pr.new/@halo-dev/console-shared@7840

@halo-dev/ui-plugin-bundler-kit

npm i https://pkg.pr.new/@halo-dev/ui-plugin-bundler-kit@7840

commit: 257f698

@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (42c374d) to head (257f698).
⚠️ Report is 198 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7840      +/-   ##
============================================
+ Coverage     59.55%   60.36%   +0.80%     
- Complexity     3812     3822      +10     
============================================
  Files           677      677              
  Lines         23248    23080     -168     
  Branches       1500     1496       -4     
============================================
+ Hits          13846    13932      +86     
+ Misses         8764     8483     -281     
- Partials        638      665      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ruibaby
ruibaby approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 7fd3cce into halo-dev:main Oct 21, 2025
12 checks passed
@ruibaby ruibaby added this to the 2.22.0 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruibaby ruibaby ruibaby approved these changes

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@ruibaby ruibaby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

在默认编辑器 /与、都可以快捷选择输入样式提示，建议学习下飞书

2 participants

@LIlGG @ruibaby