Skip to content

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 3, 2025

What type of PR is this?

/area ui
/milestone 2.22.x
/kind feature

What this PR does / why we need it:

This PR adds an option in the storage policy settings to hide a policy from the upload interface.

This is useful because some storage policies are not intended for direct user uploads. Hiding them can help declutter the UI and prevent users from selecting them by mistake.

Which issue(s) this PR fixes:

Fixes #7787

Does this PR introduce a user-facing change?

支持在附件上传界面隐藏部分存储策略

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 3, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.22.x milestone Oct 3, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wan92hen October 3, 2025 07:37
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.36%. Comparing base (42c374d) to head (45e2450).
⚠️ Report is 180 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7792      +/-   ##
============================================
+ Coverage     59.55%   60.36%   +0.81%     
- Complexity     3812     3816       +4     
============================================
  Files           677      677              
  Lines         23248    23065     -183     
  Branches       1500     1491       -9     
============================================
+ Hits          13846    13924      +78     
+ Misses         8764     8480     -284     
- Partials        638      661      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit b21e77b into halo-dev:main Oct 3, 2025
10 checks passed
@JohnNiang JohnNiang modified the milestones: 2.22.x, 2.22.0 Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to hide certain storage policies from the upload modal

2 participants