Skip to content

Add loading indicator to DefaultEditor initialization #7756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JohnNiang merged 1 commit into from
Sep 20, 2025
Merged

Add loading indicator to DefaultEditor initialization #7756

JohnNiang merged 1 commit into from
Sep 20, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 16, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

When there are multiple async extensions to load in the editor, the page might stay blank for a while, which could be confusing for users. This PR adds a loading state to address that.

Does this PR introduce a user-facing change?

为文章编辑器添加加载状态。

@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 16, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Sep 16, 2025
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 16, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG September 16, 2025 07:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Sep 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.55%. Comparing base (42c374d) to head (14ba881).
⚠️ Report is 161 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7756      +/-   ##
============================================
- Coverage     59.55%   59.55%   -0.01%     
  Complexity     3812     3812              
============================================
  Files           677      678       +1     
  Lines         23248    23294      +46     
  Branches       1500     1504       +4     
============================================
+ Hits          13846    13872      +26     
- Misses         8764     8775      +11     
- Partials        638      647       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JohnNiang
JohnNiang reviewed Sep 20, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2025
@JohnNiang JohnNiang added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang merged commit 8a7805f into halo-dev:main Sep 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

@LIlGG LIlGG Awaiting requested review from LIlGG

Assignees

@JohnNiang JohnNiang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.21.x

Development

Successfully merging this pull request may close these issues.

2 participants

@ruibaby @JohnNiang