Skip to content

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 12, 2025

What type of PR is this?

/area ui
/kind improvement
/milestone 2.21.x

What this PR does / why we need it:

Add auto-height prop to formkit textarea to support automatic resizing based on content length.

Does this PR introduce a user-facing change?

Console 端的部分多行文本输入框支持自动高度。

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 12, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Sep 12, 2025
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 12, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.55%. Comparing base (42c374d) to head (796d6ab).
⚠️ Report is 159 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7749      +/-   ##
============================================
- Coverage     59.55%   59.55%   -0.01%     
  Complexity     3812     3812              
============================================
  Files           677      678       +1     
  Lines         23248    23294      +46     
  Branches       1500     1504       +4     
============================================
+ Hits          13846    13872      +26     
- Misses         8764     8775      +11     
- Partials        638      647       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 12, 2025
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit d0f050f into halo-dev:main Sep 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants