Skip to content

Conversation

@JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area plugin
/milestone 2.21.x

What this PR does / why we need it:

This PR fixes the problem that loading resources from class path during static initialization doesn't work.

Does this PR introduce a user-facing change?

修复部分场景下无法正常启动插件的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 29, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Aug 29, 2025
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Aug 29, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and guqing August 29, 2025 03:13
@sonarqubecloud
Copy link

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@f2c-ci-robot f2c-ci-robot bot merged commit 2a37366 into main Aug 29, 2025
9 checks passed
@ruibaby ruibaby deleted the bug/plugin-classloader-not-set-for-thread branch August 29, 2025 03:33
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 10, 2025
#### What type of PR is this?

/kind improvement
/area plugin
/milestone 2.21.x

#### What this PR does / why we need it:

This PR restores context ClassLoader mangement during plugin lifecycle to prevent resource leak.

Meanwhile, it also fixes Class initialization error when starting plugins.

Superseds #7725

#### Does this PR introduce a user-facing change?

```release-note
None
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants