Skip to content

Add subject-based comment list modal #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ruibaby merged 1 commit into from
Aug 13, 2025
Merged

Add subject-based comment list modal #7681

ruibaby merged 1 commit into from
Aug 13, 2025

Conversation

@ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 12, 2025

What type of PR is this?

/area ui
/kind feature
/milestone 2.21.x

What this PR does / why we need it:

image image

Does this PR introduce a user-facing change?

Console 端文章管理支持直接打开对应的评论列表

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Aug 12, 2025
@f2c-ci-robot f2c-ci-robot bot added this to the 2.21.x milestone Aug 12, 2025
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and guqing August 12, 2025 09:53
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 12, 2025
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilgg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.49%. Comparing base (42c374d) to head (9bbb7b3).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #7681      +/-   ##
============================================
- Coverage     59.55%   59.49%   -0.07%     
+ Complexity     3812     3802      -10     
============================================
  Files           677      678       +1     
  Lines         23248    23256       +8     
  Branches       1500     1495       -5     
============================================
- Hits          13846    13836      -10     
- Misses         8764     8776      +12     
- Partials        638      644       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JohnNiang
JohnNiang approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruibaby ruibaby merged commit f5af5a1 into halo-dev:main Aug 13, 2025
7 of 8 checks passed
@ruibaby ruibaby deleted the feat/subject-comments-modal branch August 13, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@guqing guqing Awaiting requested review from guqing

Assignees

No one assigned

Labels

area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.21.x

Development

Successfully merging this pull request may close these issues.

2 participants

@ruibaby @JohnNiang