[Hexagon] - Build LLVM with Hexagon only if the builder handles hexagon #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Contributor
Author
|
@steven-johnson - PTAL |
steven-johnson
approved these changes
Aug 7, 2023
Contributor
|
landed and buildmaster updated |
Member
|
Does this affect release builds? And if so, doesn't this break the ability to cross compile for hexagon from e.g. Windows? |
Contributor
Oooh, yes, this is a good point. I'll revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes building the Hexagon backend in LLVM contingent upon the builders capability. If the builder doesn't handle hexagon there is no point building it in LLVM too.