Record trace_loads directly on ImageParam. #8803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create two ImageParams with the same name, you can only call .trace_loads() on the first one. The second one will silently do nothing. That's because of this section of code in Tracing.cpp:
...only that name gets rendered as something like
input_im$1wheninputis duplicated. It would need to be calledinput$1_imfor this logic to work.This PR fixes that issue by allowing ImageParams to be marked for tracing directly. Params initially appear in the trace before any func, so the order was changed in one of the tests.