Fix wrong type of the bound #8781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
approved these changes
Aug 27, 2025
Member
Author
|
I think there are many unrelated test failures, but the failed correctness_bounds_of_pure_intrinsics on halide-testbranch-main-llvm_main-x86-64-windows-cmake does seem to be relevant. It fails on every target (host, host-cuda, host-opencl, etc) in that run, not sure what's wrong with it? Maybe this is because the test now needs too much stack? |
Member
|
Merged with main to see if I can get some of the unrelated failures to go away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adressing a following error which we started to get after updating Halide internally:
I think the issue is that when
handle_const_arg_callreturnsfalse, the Call visitor just exits instead of hitting the else branch. This is problematic, becausehandle_const_arg_callwill visit each of the arguments and each of their visitors will setinterval, so in the endintervalwill be set to the interval of the last argument of the Call. In this case, it has a different type causing the error above.