Fix up memoize; bind to Python #8778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtzam
dismissed
their stale review
Compiler Segfaulting when using the added overload
Contributor
|
Here's a minimal python repro that segfaults at compilation time: from halide import EvictionKey, Func, Var
x = Var("x")
f = Func("f")
f[x] = 0.0
f[x] = f[x] + 1
print("memoize scheduled")
f.memoize()
# f.memoize(EvictionKey(x))
print("JIT compiling...")
f.compile_jit()
print("realizing...")
result = f.realize([3])
print(result) |
Contributor
|
Documenting slightly smaller test case demonstrating a different symptom: from halide import Func, Var
x = Var("x")
f = Func("f")
f[x] = 0.0
print("memoize scheduled")
f.memoize()
print("JIT compiling...")
f.compile_jit()
print("realizing...")
result = f.realize([3])
print(result)Which generates: f.compile_jit()
~~~~~~~~~~~~~^^
halide.halide_.HalideError: Error: Symbol not found: f.cache_missSo the pure definition is also a bit broken as well as the update step |
alexreinking
changed the title
abadams
reviewed
Aug 26, 2025
abadams
reviewed
Aug 26, 2025
abadams
reviewed
Aug 26, 2025
abadams
approved these changes
Aug 26, 2025
rtzam
approved these changes
Aug 27, 2025
Member
Author
|
Failures, although many, are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8777