Add Python bindings for serialization #8718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
force-pushed
the
python/serialization
branch
from
18b32fa to
b32a44b
Compare
steven-johnson
approved these changes
Aug 13, 2025
shoaibkamil
reviewed
Aug 13, 2025
shoaibkamil
reviewed
Aug 13, 2025
shoaibkamil
reviewed
Aug 13, 2025
shoaibkamil
reviewed
Aug 13, 2025
shoaibkamil
reviewed
Aug 13, 2025
shoaibkamil
approved these changes
Aug 13, 2025
Contributor
shoaibkamil
left a comment
shoaibkamil
left a comment
There was a problem hiding this comment.
Some nits, but LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a helpful
PathLiketype that we can maybe use elsewhere we expect to receive/return filesystem paths. I didn't go down the rabbit hole of usingstd::filesystemsince IIRC it's broken before C++20.Fixes #8716