Highlight Metal GPU code in stmt_html #8659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search the first 5 lines of the device code for the keyword `using namespace metal`. If it exists, invoke the syntax highlighting for Metal/C++ language.
mcourteaux
requested changes
Jun 24, 2025
Contributor
mcourteaux
left a comment
mcourteaux
left a comment
There was a problem hiding this comment.
Very cool! Thanks.
Two requests for change:
- Can you rename the function to
highlightDeviceCode(), and support both Metal and OpenCL. You can simply check the first line to containOpenCL. - Fix the indent of the function and the call to it.
antonysigma
commented
Jun 25, 2025
antonysigma
force-pushed
the
highlight-metal-device-code
branch
from
1a0ee08 to
023cad0
Compare
Contributor
|
Thanks. You didn't indent the code tho. Everything inside the |
antonysigma
commented
Jun 26, 2025
Contributor
Author
antonysigma
left a comment
antonysigma
left a comment
There was a problem hiding this comment.
Thanks. You didn't indent the code tho. Everything inside the <script> tag should be indented.
Done. Please review it again.
mcourteaux
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Search the first 5 lines of the device code for the keyword
using namespace metal. If it exists, invoke the syntax highlighting for Metal/C language.(Used to debug the
threads_budgetfor Metal GPUs. #8650 (comment))Screenshot:
cc'ed @mcourteaux .