[bug] Fix halide_get_cpu_features() linkage to avoid name mangling issues #8573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2025 14:59
…mangling issues. Change CpuFeatures to POD struct passed by pointer. Update all backend cpu feature implementations.
abadams
reviewed
Feb 12, 2025
added 2 commits
February 12, 2025 09:13
Contributor
Author
|
NOTE: worker arm64-linux-worker-4 has no disk space left, which is causing the llvm-20-arm32-linux-cmake build to fail. Otherwise ready to merge. |
Member
|
The macos workers succeeded, so I guess that cantFail issue showing up on other PRs was a temporary llvm issue. Some problems go away if you ignore them. |
abadams
reviewed
Feb 12, 2025
Member
|
lgtm other than suggest changing to abort_if_false |
abadams
approved these changes
Feb 12, 2025
…r error code from can_use_target_features).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the linkage of
halide_get_cpu_features(...)intoextern "C"to avoid issues with name mangling between different platform ABIs. It also changesCpuFeaturesinto a POD struct, which is passed by pointer to allow C linkage.Fixes: #8565