Skip to content

Apply version constraints to iOS objects #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexreinking merged 1 commit into from
Jan 12, 2025
Merged

Apply version constraints to iOS objects #8546

alexreinking merged 1 commit into from
Jan 12, 2025

Conversation

@alexreinking
Copy link
Member

@alexreinking alexreinking commented Jan 7, 2025

Fixes linker errors of the form

ld: warning: no platform load command found in 'library.a[2](object.o)', assuming: iOS

If 17 is too restrictive, we can always drop it to be more permissive later.

@alexreinking alexreinking added backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases. labels Jan 7, 2025
@jiawen
Copy link
Contributor

jiawen commented Jan 7, 2025

Thanks Alex! I guess I'll wait for Halide 20 (or maybe 19.x if gets backported?)

@alexreinking alexreinking merged commit 5f56f68 into main Jan 12, 2025
19 checks passed
@vksnk
Copy link
Member

vksnk commented Apr 17, 2025

This change seems to cause a linker error in one of our internal projects, the error message it gives is: ld: building for 'iOS-simulator', but linking in object file <object_file_name> built for 'iOS' . I tried to figure out how to fix it myself, but wasn't very successful (I know very little about iOS development, so not really surprising), so would appreciate any help.

@jiawen
Copy link
Contributor

jiawen commented Apr 17, 2025

This change seems to cause a linker error in one of our internal projects, the error message it gives is: ld: building for 'iOS-simulator', but linking in object file <object_file_name> built for 'iOS' . I tried to figure out how to fix it myself, but wasn't very successful (I know very little about iOS development, so not really surprising), so would appreciate any help.

Is this an error or just a warning?

This is annoying though. LLVM's Triple treats iOS as an "OS". But ld wants to be more fine grained. Maybe Environment = Simulator might work?

@vksnk
Copy link
Member

vksnk commented Apr 17, 2025

It's an error clang: error: linker command failed with exit code 1

@alexreinking alexreinking deleted the ios-linker branch April 18, 2025 16:29
@BrewTestBot BrewTestBot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees

No one assigned

Labels

backport me This change should be backported to release versions release_notes For changes that may warrant a note in README for official releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexreinking @jiawen @vksnk @steven-johnson