Don't let users disguise RVars as Vars #8441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
approved these changes
Oct 18, 2024
There was one instance in fit_function.cpp, and the autoscheduler was doing it in the generated schedules. This may cause errors in existing generated schedules that have been checked in.
Member
Author
|
This uncovered an error where our generated schedules from adams2019 were incorrectly declaring some RVars as Vars. The scheduling directives used are the ones that are legal for RVars, so there should not be any incorrect output, but adding this check may cause existing checked-in generated schedules to throw a compile-time error. This can be manually fixed up by changing the declaration to be an RVar. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7827