-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Two more build fixes #8371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two more build fixes #8371
Conversation
It is not known by GCC13: https://ci.debian.net/packages/h/halide/testing/i386/50047733/ and fails with ``` /usr/bin/g++ -DHALIDE_ENABLE_RTTI -DHALIDE_VERSION_MAJOR=18 -DHALIDE_VERSION_MINOR=0 -DHALIDE_VERSION_PATCH=0 -DHALIDE_WITH_EXCEPTIONS -isystem /usr/include/halide18 -O3 -DNDEBUG -MD -MT CMakeFiles/main.dir/main.cpp.o -MF CMakeFiles/main.dir/main.cpp.o.d -o CMakeFiles/main.dir/main.cpp.o -c /tmp/autopkgtest.pviDWM/build.Sjp/src/test/integration/jit/main.cpp In file included from /tmp/autopkgtest.pviDWM/build.Sjp/src/test/integration/jit/main.cpp:1: /usr/include/halide18/Halide.h: In member function ‘Halide::float16_t::operator _Float16() const’: /usr/include/halide18/Halide.h:3054:40: error: SSE register return with SSE2 disabled 3054 | explicit operator _Float16() const { | ^ /usr/include/halide18/Halide.h:3057:16: error: SSE register return with SSE2 disabled 3057 | return result; | ^~~~~~ /usr/include/halide18/Halide.h: In constructor ‘Halide::Expr::Expr(_Float16)’: /usr/include/halide18/Halide.h:4679:64: error: invalid conversion from type ‘_Float16’ without option ‘-msse2’ 4679 | : IRHandle(Internal::FloatImm::make(Float(16), (double)x)) { | ^ ninja: build stopped: subcommand failed. ``` with GCC14.
|
CMake honors the CXX environment variable. Is that getting unset somehow? |
|
It's not getting pass-through either: |
Strange, but thanks for trying. I'll approve this. |
|
As usual, osx is being oh so picky. |
|
That particular failure is fixed by #8381 |
|
@alexreinking @steven-johnson thank you! |
Without
CXXpropagation, there isn't really any way to test with any but default compiler.In fact, that happened to be GCC, and on i386 the test didn't pass, even though the package built,
because it was built with clang. The second patch addresses the GCC failure on i386,
but there are more issues on other architectures i strongly suspect.