Fix inverted may_subtile checks #7626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
added
autoscheduler
steven-johnson
approved these changes
Jun 12, 2023
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
Wow, this was a pretty big mistake on my part :-/
Member
Author
More like a weakness in our testing for the autoschedulers. |
Member
Author
|
Failures unrelated |
Member
Author
|
@derek-gerstmann This fixed the issue blocking the 16 release |
Contributor
|
@abadams Thx! I'll start coordinating the v16 branch and prepare things for the release! |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was massively restricting the search space of the autoscheduler, making it faster but excluding most interesting schedules (e.g. all sliding window ones).
Fixes #7531
May also relate to #7623