Rewrite python_bindings/apps #7133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-johnson
added
backport me
abadams
reviewed
Oct 28, 2022
abadams
reviewed
Oct 28, 2022
abadams
reviewed
Oct 28, 2022
Contributor
Author
|
Monday Morning Review Ping |
Member
|
Are these apps run in CI? I can't figure out which builder does it. |
Contributor
Author
Yes, anything that runs the |
abadams
approved these changes
Oct 31, 2022
steven-johnson
added a commit
that referenced
this pull request
Oct 31, 2022
* apps * wip * WIP 2 * Fix comments * _GPU_SCHEDULE_ENUM_MAP * Update blur_generator.py * Add hl.funcs, hl.vars, plus formatting tweaks
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* apps * wip * WIP 2 * Fix comments * _GPU_SCHEDULE_ENUM_MAP * Update blur_generator.py * Add hl.funcs, hl.vars, plus formatting tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apps were pretty old; none used Generators (though they really should have); most of them had very limited scheduling options. I updated all of them based on the equivalent C++ app, moved them to be Generator based (and self-contained instead of mixed in with the tests), and nuked the
erodeapp entirely since it was of dubious use and had no C++ counterpart. Also formatted all of them with Black (https://github.com/psf/black), which is one of most popular Python formatters. The goal here is to ensure that the apps here are good examples of "best practices" for Halide Python use as of Halide 15.