Skip to content

[APP] Fix hexagon_benchmarks build (use two-var prefetch) #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steven-johnson merged 4 commits into from
Jan 18, 2022
Merged

[APP] Fix hexagon_benchmarks build (use two-var prefetch) #6563

steven-johnson merged 4 commits into from
Jan 18, 2022

Conversation

@masahi
Copy link
Contributor

@masahi masahi commented Jan 15, 2022

Fix the following error when compiling hexgaon_benchmarks app:

Halide/distrib/include/Halide.h:24829:77: error: ‘Halide::Func& Halide::Func::prefetch(const T&, Halide::VarOrRVar, int, Halide::PrefetchBoundStrategy) [with T = Halide::GeneratorInput<Halide::Buffer<unsigned char> >]’ is deprecated: Call prefetch() with the two-var form instead. [-Werror=deprecated-declarations]
24829 |         return this->template as<Class>().Method(std::forward<Args>(args)...)

@pranavb-ca pranavb-ca self-requested a review January 15, 2022 23:17
steven-johnson
steven-johnson approved these changes Jan 16, 2022
View reviewed changes
Copy link
Contributor

@steven-johnson steven-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green

@steven-johnson
Copy link
Contributor

steven-johnson commented Jan 18, 2022

Failure is unrelated, landing

@steven-johnson steven-johnson merged commit 77de08c into halide:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

@pranavb-ca pranavb-ca pranavb-ca approved these changes

@halidebuildbots halidebuildbots Awaiting requested review from halidebuildbots

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@masahi @steven-johnson @pranavb-ca