Codegen_C: buffer compilation needs to special-case scalar buffers #6442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code will emit something like `halide_dimension_t foo_buffer_shape[] = {};` for these, which is a zero-length array, which some compilers will (justifiably) say has no effect. We should be able to just use nullptr for the shape in these cases.
dsharletg
approved these changes
Nov 23, 2021
| stream << "halide_dimension_t(" << buffer.dim(i).min() | ||
| << ", " << buffer.dim(i).extent() | ||
| << ", " << buffer.dim(i).stride() << ")"; | ||
| if (i < buffer.dimensions() - 1) { |
Contributor
There was a problem hiding this comment.
An alternative (maybe simpler) solution is to just emit a dummy default constructed halide_dimension_t, i.e. {{}}.
Contributor
Author
There was a problem hiding this comment.
True, but then we need to allocate a (trivial) amount of extra space for dimensions that shouldn't ever be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code will emit something like
halide_dimension_t foo_buffer_shape[] = {};for these, which is a zero-length array, which some compilers will (justifiably) say has no effect. We should be able to just use nullptr for the shape in these cases.