Fixed a small bug in interleave_vectors #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttempted to interleave 4 vectors of a 64-bit type. Solution is to check bit width of the type and fall back to the recursive interleave if the vectors have 64-bit elements.
Member
|
By "bug" do you mean poor assembly generated, or do you actually mean you get the wrong result out? |
Contributor
Author
|
The codegen would actually fail because it attempts to cast the partially interleaved vectors to a 128-bit type, e.g. a vector of float128's, which doesn't exist in llvm. |
abadams
added a commit
that referenced
this pull request
Jan 21, 2015
Fixed a small bug in interleave_vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for a small bug. This only appeared when one attempted to interleave 4 vectors of a 64-bit type. Solution is to check bit width of the type and fall back to the recursive interleave if the vectors have 64-bit elements.