Fix printf parameters rule

Kolyunya · ondrejmirtes · commit 023fa08d52a2 · 2017-04-06T10:40:05.000+02:00
diff --git a/src/Rules/Functions/PrintfParametersRule.php b/src/Rules/Functions/PrintfParametersRule.php
@@ -82,7 +82,7 @@ public function processNode(Node $node, Scope $scope): array
 	private function getPlaceholdersCount(string $functionName, string $format): int
 	{
 		$specifiers = in_array($functionName, ['sprintf', 'printf'], true) ? '[bcdeEfFgGosuxX]' : '(?:[cdDeEfinosuxX]|\[\^[^\]]+\])';
-		$pattern = '~(?<before>%*)%(?:(?<position>\d+)\$)?[-+]?(?:[ 0]|(?:\'[^%]))?-?\d*(?:\.\d+)?' . $specifiers . '~';
+		$pattern = '~(?<before>%*)%(?:(?<position>\d+)\$)?[-+]?(?:[ 0]|(?:\'[^%]))?-?\d*(?:\.\d*)?' . $specifiers . '~';
 
 		if (!preg_match_all($pattern, $format, $matches, PREG_SET_ORDER)) {
 			return 0;
diff --git a/tests/PHPStan/Rules/Functions/data/printf.php b/tests/PHPStan/Rules/Functions/data/printf.php
@@ -33,3 +33,7 @@
 sscanf($str, "%20[^\n]\n%d", $string, $number); // ok
 sscanf($str, "%20[^\n]\r\n%d", $string, $number); // ok
 sscanf($str, "%20[^abcde]a%d", $string, $number); // ok
+printf("%.E", 3.14159); // ok
+sprintf("%.E", 3.14159); // ok
+sscanf($str, '%.E', $number); // ok
+fscanf($str, '%.E', $number); // ok

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function processNode(Node $node, Scope $scope): array`
`82`	`82`	`private function getPlaceholdersCount(string $functionName, string $format): int`
`83`	`83`	`{`
`84`	`84`	`$specifiers = in_array($functionName, ['sprintf', 'printf'], true) ? '[bcdeEfFgGosuxX]' : '(?:[cdDeEfinosuxX]\|\[\^[^\]]+\])';`
`85`		`- $pattern = '~(?<before>%)%(?:(?<position>\d+)\$)?[-+]?(?:[ 0]\|(?:\'[^%]))?-?\d(?:\.\d+)?' . $specifiers . '~';`
	`85`	`+ $pattern = '~(?<before>%)%(?:(?<position>\d+)\$)?[-+]?(?:[ 0]\|(?:\'[^%]))?-?\d(?:\.\d*)?' . $specifiers . '~';`
`86`	`86`
`87`	`87`	`if (!preg_match_all($pattern, $format, $matches, PREG_SET_ORDER)) {`
`88`	`88`	`return 0;`