fix: change PrimaryColumn decorator to clone passed options (typeorm#4571)

sthuck · pleerock · commit 3cf470d92a54 · 2019-09-05T20:46:19.000+05:00
Closes: typeorm#4570
diff --git a/src/decorator/columns/PrimaryColumn.ts b/src/decorator/columns/PrimaryColumn.ts
@@ -31,7 +31,7 @@ export function PrimaryColumn(typeOrOptions?: ColumnType|ColumnOptions, options?
         if (typeof typeOrOptions === "string") {
             type = <ColumnType> typeOrOptions;
         } else {
-            options = <ColumnOptions> typeOrOptions;
+            options = Object.assign({}, <ColumnOptions> typeOrOptions);
         }
         if (!options) options = {} as ColumnOptions;
 
diff --git a/test/github-issues/4570/issue-4570.ts b/test/github-issues/4570/issue-4570.ts
@@ -0,0 +1,19 @@
+import "reflect-metadata";
+
+import {expect} from "chai";
+import {ColumnOptions, PrimaryColumn} from "../../../src";
+
+describe("github issues > #4570 Fix PrimaryColumn decorator modifies passed option", () => {
+    it("should not modify passed options to PrimaryColumn", () => {
+        const options: ColumnOptions = {type: "varchar" };
+        const clone = Object.assign({}, options);
+
+        class Entity {
+            @PrimaryColumn(options)
+            pkey: string;
+        }
+
+        expect(Entity).to.be;
+        expect(clone).to.be.eql(options);
+    });
+});

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export function PrimaryColumn(typeOrOptions?: ColumnType\|ColumnOptions, options?`
`31`	`31`	`if (typeof typeOrOptions === "string") {`
`32`	`32`	`type = <ColumnType> typeOrOptions;`
`33`	`33`	`} else {`
`34`		`- options = <ColumnOptions> typeOrOptions;`
	`34`	`+ options = Object.assign({}, <ColumnOptions> typeOrOptions);`
`35`	`35`	`}`
`36`	`36`	`if (!options) options = {} as ColumnOptions;`
`37`	`37`