Skip to content

Support dynamic registration from open generic type#200

Closed
hadashiA wants to merge 1 commit intomasterfrom
ku/open-generics
Closed

Support dynamic registration from open generic type#200
hadashiA wants to merge 1 commit intomasterfrom
ku/open-generics

Conversation

@hadashiA
Copy link
Copy Markdown
Owner

@hadashiA hadashiA commented Apr 24, 2021 •
edited
Loading

#301

If the open generic type is registered, the closed generic type will be dynamically assembled at resolve time.

builder.Register(typeof(IFoo<,>), typeof(Foo<,>))

📝 Usage:
https://github.com/Cysharp/MessagePipe/blob/master/src/MessagePipe/ServiceCollectionExtensions.cs#L43-L102

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 24, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hadashia/vcontainer/BeCZQEMCyDrYStHXQN76EX5aXLAt
✅ Preview: https://vcontainer-git-ku-open-generics-hadashia.vercel.app

@hadashiA hadashiA changed the title Support for open generics Support dynamic registration from open generic type Apr 28, 2021
@hadashiA hadashiA force-pushed the ku/open-generics branch from a93cac2 to 3edb2bd Compare May 5, 2021 02:38
@hadashiA hadashiA force-pushed the ku/open-generics branch from 3edb2bd to d7771fd Compare May 5, 2021 10:28
@igor84
Copy link
Copy Markdown

igor84 commented Aug 21, 2022

Since this approach is only making instances of the closed generic types using reflection it means it won't work with IL2CPP, right? It will only work if code generation is used since it will then generate the code that actually uses those types so they won't be missing in runtime.

@hadashiA hadashiA mentioned this pull request Oct 30, 2022
Merged
@hadashiA
Copy link
Copy Markdown
Owner Author

hadashiA commented Dec 23, 2023

I decided to adopt this one. #367

MakeGenericType seems to work in recent Unity. See also the comments.

@hadashiA hadashiA closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hadashiA @igor84