You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e2aa2ea
Browse filesBrowse the repository at this point in the historyBrowse files
[google_maps_flutter_web] Avoid replacing advanced marker content on move (flutter#11952)
## Description
Avoid replacing an `AdvancedMarkerElement`'s DOM content when a marker update changes only its position. Recreating byte-backed bitmap content produces a new blob-backed image node, which causes the marker to disappear or flicker while moving.
The web implementation now tracks the marker properties that affect rendered content (icon configuration, alpha, visibility, and rotation). Position-only updates preserve the existing DOM node; visual changes still replace it.
Fixesflutter/flutter#188291.
## Tests
- Added web integration coverage for repeated position updates using both `BitmapDescriptor.bytes` and `BytesMapBitmap`.
- Added coverage that visual configuration changes replace the content.
- Ran formatting, analysis, Dart tests, package validation, and publish checks for `google_maps_flutter_web`.
- Ran `advanced_markers_test.dart` through `flutter drive` in Chrome.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_web/example/latest/integration_test/advanced_markers_test.dart
+103Lines changed: 103 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -335,6 +335,109 @@ void main() {
335
335
expect(icon.style.height, '${expectedSize}px');
336
336
});
337
337
338
+
for (final descriptorFactory in<(String, BitmapDescriptorFunction(Uint8List))>[
0 commit comments