Skip to content

fix: java.util.ConcurrentModificationException on multiple hCaptcha v…#198

Merged
CAMOBAP merged 1 commit intomainfrom
bugfix/concurrent-modification-exception
Aug 31, 2025
Merged

fix: java.util.ConcurrentModificationException on multiple hCaptcha v…#198
CAMOBAP merged 1 commit intomainfrom
bugfix/concurrent-modification-exception

Conversation

@CAMOBAP
Copy link
Copy Markdown
Collaborator

@CAMOBAP CAMOBAP commented Aug 26, 2025

…erify calls

@CAMOBAP CAMOBAP requested review from DSergiu and e271828- August 26, 2025 23:18
@CAMOBAP CAMOBAP self-assigned this Aug 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2025 •
edited
Loading

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new      │ diff  
──────────┼───────────┼──────────┼───────
      jar │  54.3 KiB │ 54.4 KiB │ +19 B 
 manifest │     411 B │    411 B │   0 B 
      res │  78.2 KiB │ 78.2 KiB │   0 B 
    other │     989 B │    989 B │   0 B 
──────────┼───────────┼──────────┼───────
    total │ 133.9 KiB │  134 KiB │ +19 B 

 JAR     │ old │ new │ diff      
─────────┼─────┼─────┼───────────
 classes │  36 │  36 │ 0 (+0 -0) 
 methods │ 522 │ 522 │ 0 (+5 -5) 
  fields │ 164 │ 164 │ 0 (+3 -3)
AAR 
 size     │ diff  │ path          
──────────┼───────┼───────────────
 54.4 KiB │ +19 B │ ∆ classes.jar 
──────────┼───────┼───────────────
 54.4 KiB │ +19 B │ (total)
JAR 
METHODS:

   old │ new │ diff      
  ─────┼─────┼───────────
   522 │ 522 │ 0 (+5 -5) 
  
  + java.util.concurrent.CopyOnWriteArrayList <init>()
  + java.util.concurrent.CopyOnWriteArrayList add(Object) → boolean
  + java.util.concurrent.CopyOnWriteArrayList clear()
  + java.util.concurrent.CopyOnWriteArrayList iterator() → Iterator
  + java.util.concurrent.CopyOnWriteArrayList remove(Object) → boolean
  
  - java.util.ArrayList <init>()
  - java.util.List add(Object) → boolean
  - java.util.List clear()
  - java.util.List iterator() → Iterator
  - java.util.List remove(Object) → boolean
  

FIELDS:

   old │ new │ diff      
  ─────┼─────┼───────────
   164 │ 164 │ 0 (+3 -3) 
  
  + com.hcaptcha.sdk.tasks.Task onFailureListeners: CopyOnWriteArrayList
  + com.hcaptcha.sdk.tasks.Task onOpenListeners: CopyOnWriteArrayList
  + com.hcaptcha.sdk.tasks.Task onSuccessListeners: CopyOnWriteArrayList
  
  - com.hcaptcha.sdk.tasks.Task onFailureListeners: List
  - com.hcaptcha.sdk.tasks.Task onOpenListeners: List
  - com.hcaptcha.sdk.tasks.Task onSuccessListeners: List

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 26, 2025 •
edited
Loading

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +387.19 -3
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +411.38 +108
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -1.36 +100.25
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -14.85 -5598
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +23.36 -21

@CAMOBAP CAMOBAP force-pushed the bugfix/concurrent-modification-exception branch from 0a2d4a9 to bdd4fec Compare August 30, 2025 22:46
@CAMOBAP CAMOBAP merged commit 6d37bbe into main Aug 31, 2025
11 checks passed
@CAMOBAP CAMOBAP deleted the bugfix/concurrent-modification-exception branch August 31, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e271828- e271828- e271828- approved these changes

@DSergiu DSergiu Awaiting requested review from DSergiu

Assignees

@CAMOBAP CAMOBAP

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CAMOBAP @e271828- @alexbabrykovich