Skip to content

fix: activity leak in HCaptchaDebugInfo #195#197

Merged
e271828- merged 4 commits intomainfrom
bugfix/activity-leak
Aug 31, 2025
Merged

fix: activity leak in HCaptchaDebugInfo #195#197
e271828- merged 4 commits intomainfrom
bugfix/activity-leak

Conversation

@CAMOBAP
Copy link
Copy Markdown
Collaborator

@CAMOBAP CAMOBAP commented Aug 19, 2025 •
edited by e271828-
Loading

Closes #195

@CAMOBAP CAMOBAP self-assigned this Aug 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 19, 2025 •
edited
Loading

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────
      jar │  54.3 KiB │  54.6 KiB │ +274 B 
 manifest │     411 B │     411 B │    0 B 
      res │  78.2 KiB │  78.2 KiB │    0 B 
    other │     989 B │     989 B │    0 B 
──────────┼───────────┼───────────┼────────
    total │ 133.9 KiB │ 134.2 KiB │ +274 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  36 │  36 │  0 (+0 -0) 
 methods │ 522 │ 525 │ +3 (+4 -1) 
  fields │ 164 │ 164 │  0 (+1 -1)
AAR 
 size     │ diff   │ path          
──────────┼────────┼───────────────
 54.6 KiB │ +274 B │ ∆ classes.jar 
──────────┼────────┼───────────────
 54.6 KiB │ +274 B │ (total)
JAR 
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   522 │ 525 │ +3 (+4 -1) 
  
  + com.hcaptcha.sdk.HCaptchaDebugInfo <init>(WeakReference)
  + com.hcaptcha.sdk.HCaptchaDebugInfo getContextRef() → WeakReference
  + java.lang.ref.Reference get() → Object
  + java.lang.ref.WeakReference <init>(Object)
  
  - com.hcaptcha.sdk.HCaptchaDebugInfo getContext() → Context
  

FIELDS:

   old │ new │ diff      
  ─────┼─────┼───────────
   164 │ 164 │ 0 (+1 -1) 
  
  + com.hcaptcha.sdk.HCaptchaDebugInfo contextRef: WeakReference
  
  - com.hcaptcha.sdk.HCaptchaDebugInfo context: Context

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 19, 2025 •
edited
Loading

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +364.39 -3
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +417.88 +104
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup +0.65 +95.50
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -9.41 -5594
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +28.66 +15

@CAMOBAP CAMOBAP marked this pull request as ready for review August 26, 2025 22:05
@CAMOBAP CAMOBAP requested review from DSergiu and e271828- August 26, 2025 22:05
@hCaptcha hCaptcha deleted a comment from CAMOBAP Aug 27, 2025
@e271828- e271828- merged commit 1682a6f into main Aug 31, 2025
11 checks passed
@e271828- e271828- deleted the bugfix/activity-leak branch August 31, 2025 22:42
@hCaptcha hCaptcha deleted a comment from brsbstfxeal-art Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DSergiu DSergiu DSergiu approved these changes

@e271828- e271828- Awaiting requested review from e271828-

Assignees

@CAMOBAP CAMOBAP

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory Leak when running passive captcha

4 participants

@CAMOBAP @DSergiu @e271828- @alexbabrykovich