Skip to content

fix: accept hostname instead of url in host config#196

Merged
e271828- merged 2 commits intomainfrom
chore/check-host-param
Aug 31, 2025
Merged

fix: accept hostname instead of url in host config#196
e271828- merged 2 commits intomainfrom
chore/check-host-param

Conversation

@CAMOBAP
Copy link
Copy Markdown
Collaborator

@CAMOBAP CAMOBAP commented Aug 14, 2025

@CAMOBAP CAMOBAP requested a review from e271828- August 14, 2025 20:50
@CAMOBAP CAMOBAP self-assigned this Aug 14, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025 •
edited
Loading

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old      │ new       │ diff   
──────────┼──────────┼───────────┼────────
      jar │ 54.4 KiB │  54.7 KiB │ +378 B 
 manifest │    411 B │     411 B │    0 B 
      res │ 78.2 KiB │  78.2 KiB │    0 B 
    other │    989 B │     989 B │    0 B 
──────────┼──────────┼───────────┼────────
    total │  134 KiB │ 134.3 KiB │ +378 B 

 JAR     │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  36 │  36 │  0 (+0 -0) 
 methods │ 522 │ 526 │ +4 (+9 -5) 
  fields │ 164 │ 164 │  0 (+3 -3)
AAR 
 size     │ diff   │ path          
──────────┼────────┼───────────────
 54.7 KiB │ +378 B │ ∆ classes.jar 
──────────┼────────┼───────────────
 54.7 KiB │ +378 B │ (total)
JAR 
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   522 │ 526 │ +4 (+9 -5) 
  
  + com.hcaptcha.sdk.HCaptchaConfig getBaseUrl() → String
  + java.lang.String contains(CharSequence) → boolean
  + java.lang.String isEmpty() → boolean
  + java.lang.String trim() → String
  + java.util.ArrayList <init>()
  + java.util.List add(Object) → boolean
  + java.util.List clear()
  + java.util.List iterator() → Iterator
  + java.util.List remove(Object) → boolean
  
  - java.util.concurrent.CopyOnWriteArrayList <init>()
  - java.util.concurrent.CopyOnWriteArrayList add(Object) → boolean
  - java.util.concurrent.CopyOnWriteArrayList clear()
  - java.util.concurrent.CopyOnWriteArrayList iterator() → Iterator
  - java.util.concurrent.CopyOnWriteArrayList remove(Object) → boolean
  

FIELDS:

   old │ new │ diff      
  ─────┼─────┼───────────
   164 │ 164 │ 0 (+3 -3) 
  
  + com.hcaptcha.sdk.tasks.Task onFailureListeners: List
  + com.hcaptcha.sdk.tasks.Task onOpenListeners: List
  + com.hcaptcha.sdk.tasks.Task onSuccessListeners: List
  
  - com.hcaptcha.sdk.tasks.Task onFailureListeners: CopyOnWriteArrayList
  - com.hcaptcha.sdk.tasks.Task onOpenListeners: CopyOnWriteArrayList
  - com.hcaptcha.sdk.tasks.Task onSuccessListeners: CopyOnWriteArrayList

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2025 •
edited
Loading

Benchmark report:

Test name Time ms. (median) Allocations (median)
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerification +321.65 0
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleVerificationColdRun +382.40 +133
com.hcaptcha.sdk.HCaptchaBenchmarkTest.EMULATOR_UNLOCKED_benchmarkInvisibleSetup -0.77 +125.83
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugInfo -28.27 -5598
com.hcaptcha.sdk.HCaptchaDebugInfoTest.EMULATOR_UNLOCKED_benchmarkDebugSys +18.90 -21

@CAMOBAP
Copy link
Copy Markdown
Collaborator Author

CAMOBAP commented Aug 15, 2025

@e271828- it seems like secrets.SONAR_TOKEN is expired, could you please update it

@CAMOBAP CAMOBAP force-pushed the chore/check-host-param branch from c55ef8b to 5167d37 Compare August 31, 2025 19:35
@e271828- e271828- changed the title fix: accept hostname instead url in host config fix: accept hostname instead of url in host config Aug 31, 2025
@e271828- e271828- merged commit 27d876d into main Aug 31, 2025
11 checks passed
@e271828- e271828- deleted the chore/check-host-param branch August 31, 2025 22:28
@e271828- e271828- mentioned this pull request Aug 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e271828- e271828- e271828- approved these changes

Assignees

@CAMOBAP CAMOBAP

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CAMOBAP @e271828- @alexbabrykovich