Repository navigation
Add filters() method to variables - #307
Conversation
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
f07d297 to
e895b96
Compare
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
In an attempt to build up parity with netCDF4, i'm proposing we add the filters() method to Variable. It is used by xarray in https://github.com/pydata/xarray/blob/8d271fb393372bcd2ed6ab60c9f469a1625a4aed/xarray/backends/netCDF4_.py#L555 I'm hoping to get better cross engine support
aa10ef3 to
389dbc4
Compare
389dbc4 to
eae6712
Compare
|
Are you ok with dropping python 3.11? Personally, i could fix the failing test somehow, but the whole point of SPEC0 is to shed this maintenance burden to allow us to get back to the fun stuff that motivated us to write this software in the first place. As a volunteer, i'm very tempted to stop here, and to code less.
|
|
@hmaarrfk I'm currently still off-line (no, not really, but time is limited). Back in two days. The h5py3 hdf5 1.10 tests (3.11, 3.11, 1.10.*, 1) CI run is for keeping testing still used by debian packaging. Let's just deactivate your test for the old platform for now. |
|
Thanks for the note it seems that you have an idea on how to simplify this in a straightforward manner. I'll let you execute on this when you get back to OSS. |
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
kmuehlbauer
changed the title
|
@hmaarrfk Can you please have a look here? The issue was older netcdf4-python. I've added a fix, which should get us go for now. |
|
Thanks. Good enough for me. |
|
Thanks @hmaarrfk! |
|
Do keep in mind that the tests that failed are for Debian which hasn’t updated the version of h5netcdf in years. They are very unlikely to do so after this update. |
|
Yes, they will probably create an issue here, if there is anything bad happening on their side. |
|
Not sure if it is possible to have a new release for this. I’m trying to test this with xarray to get closer to parity with netcdf4 |
|
@hmaarrfk Yes, this is on the list for this very week. |
|
Awesome thanks! |
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
We were trying to figure why certain compression features were not included in our h5netcdf backend. This PR to h5netcdf should provide the filters variable, but I understand that it is too bleeding edge for you all to pin to h5netcdf/h5netcdf#307
In an attempt to build up parity with netCDF4, i'm proposing we add the filters() method to Variable.
It is used by xarray in
https://github.com/pydata/xarray/blob/8d271fb393372bcd2ed6ab60c9f469a1625a4aed/xarray/backends/netCDF4_.py#L555
I'm hoping to get better cross engine support
CHANGELOG.rst