feat: stale decision commit warnings#53
Merged
Koukyosyumei merged 2 commits intoJun 24, 2026
Merged
Conversation
d227459 to
c6d3a21
Compare
Collaborator
|
Thanks for the proposal and implementation! Right now, improving the other commands is a higher priority, but I’ll record this in the roadmap and merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directly extends decisions --stale feature. When
h5i commitruns, check whether the staged diff touches a line near a previously recorded stale decision. If so, print an inline warning before the commit completes:⚠ Commit touches src/repository.rs:88 near a stale decision from abc123: "chose JSON over binary"
reason was: reduces parse overhead at startup
Has this reasoning changed? Run
h5i decisions --stalefor details.Design
git2::Patchagainst the decision's recordedfile:linelocation (±CONTEXT_LINESproximity). File-level matching produces too many false positives on large files.ModifiedandFreshentries are dropped. Only decisions with similarity < 0.5 produce a warning.Testing
Two unit tests added:
fires_when_line_touched— hunk spanning the decision line triggers the warningsilent_when_far— hunk far from the decision line produces no warning